Summary

This is a follow-up to #1348, which fixed the main unbounded WHERE growth bug by separating the request sent to the backend from the predicate recorded for tracking.

This PR finishes the remaining correctness work around DeduplicatedLoadSubset:

• dedupe in-flight narrowed requests against the original request intent rather than the narrowed backend predicate
• defensively clone stored orderBy and cursor options so later caller mutation cannot corrupt dedupe state
• add regression coverage for filtered-then-unfiltered loads, repeated unfiltered loads, in-flight loadSubset({}) dedupe, and limited-query mutation safety

What Additional Work Was Done Beyond #1348

PR #1348 introduced the trackingOptions vs loadOptions split so updateTracking() no longer records narrowed NOT(...) difference predicates as if they were the original request. That fixes the main expression-growth bug.

This follow-up adds two missing pieces:

• inflightCalls.options now stores trackingOptions instead of loadOptions. Without this, a second loadSubset({}) call arriving while the first narrowed loadSubset({}) was still in flight would compare against NOT(...) instead of the original unfiltered request and would issue an unnecessary duplicate request.
• cloneOptions() now clones orderBy clauses and compareOptions, and shallowly clones cursor. Without this, callers mutating reused options objects after the first request could mutate limitedCalls / inflightCalls state and break later dedupe decisions.

Why This Matters

These follow-up fixes close the two gaps left after #1348:

• the system now treats in-flight requests the same way it treats completed requests, using the original request intent for subset matching
• stored dedupe state is no longer vulnerable to later caller mutation of pagination metadata

Together with the original #1348 fix, this makes the deduper consistent in all three places that matter:

• backend request optimization uses the narrowed predicate
• tracking uses the original request
• in-flight dedupe also uses the original request

Test Plan

Checks performed for this branch:

• pnpm vitest run packages/db/tests/query/subset-dedupe.test.ts
• IDE diagnostics on the edited files (subset-dedupe.ts, subset-dedupe.test.ts) reported no linter errors

Regression coverage added/expanded in packages/db/tests/query/subset-dedupe.test.ts:

• filtered IN(...) load followed by unfiltered load sets full-coverage state and dedupes later unfiltered calls
• filtered eq(...) load followed by unfiltered load dedupes later unfiltered and filtered calls
• repeated unfiltered loads do not keep issuing larger nested predicates
• identical all-data requests dedupe while the first narrowed all-data request is still in flight
• caller mutation of a reused limited-query orderBy does not mutate stored dedupe state

Made with Cursor